Disallow ? as a type name
#8735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
requested changes
Apr 20, 2020
There was a problem hiding this comment.
I don't like the duplication in Parser here. It feels brittle. If we ever think of a new way to create types, I am sure this will slip through and they won't be checked for "?". We could do it in Typer, then it would be just one place, when we typecheck a TypeDef. Did you consider that?
|
Yeah the duplication isn't great, I didn't think of doing it in typer, I'll give it a go. |
smarter
force-pushed
the
disallow-tparam-questionmark
branch
from
7322ab1 to
d08b906
Compare
odersky
requested changes
Apr 21, 2020
| @@ -2321,6 +2321,13 @@ class Typer extends Namer | |||
| val typer1 = localTyper(sym) | |||
| typer1.typedDefDef(tree, sym)(using ctx.localContext(tree, sym).setTyper(typer1)) | |||
| case tree: untpd.TypeDef => | |||
| if tree.name eq tpnme.? then | |||
| val addendum = if sym.owner.is(TypeParam) | |||
There was a problem hiding this comment.
I'd move the whole case into a new method typedTypeOrCassDef, in order to keep the dispatch code in typedUnnamed as small as possible. That often helps the JIT to opimize.
smarter
force-pushed
the
disallow-tparam-questionmark
branch
from
d08b906 to
4a71417
Compare
Now that we use `?` for wildcards, we should treat it more like a keyword for types and not allow it as a type name to avoid confusion.
smarter
force-pushed
the
disallow-tparam-questionmark
branch
from
4a71417 to
30aa58d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we use
?for wildcards, we should treat it more like akeyword for types and not allow it as a type name to avoid
confusion.